global behavior if commonjs not available#6
global behavior if commonjs not available#6lgrignon wants to merge 2 commits intoerrwischt:masterfrom
Conversation
|
NB: travis build fails but it seems to be not related |
|
Fixed by upgrading node version. If you could please merge & deploy to npm, it would be great :) |
|
|
||
|
|
||
| module.exports = StackTraceParser; | ||
| if (typeof module != 'undefined') { |
There was a problem hiding this comment.
Hmm, that is enough? The main entry point of the project is the index.js which also uses module.exports to require that stuff.
|
What is the problem you are trying to solve? Do you want to use this in a browser? I think there are way more possibilities to get this to run in browser nowadays. |
|
I run it into a browser. I cannot use a module shim for many reasons. And yes, it is enough to run it in a browser since I made it work yesterday :) (However, I include the stacktrace-parser.js file instead of the index.js) |
|
@lgrignon I just merged a complete update to the product using babel. I guess that would solve your problem when releasing a new version, right? |
|
FYI @Calamari this would be fixed by simply linking |
3 participants
Sorry, just a small fix to use this in a browser by simply importing it through a script tag.
Thanks for your simple, but useful library :)